Skip to content

[smg][ci] migrate validation tests to new infrastructure#16746

Merged
slin1237 merged 1 commit intomainfrom
smg-ci-n/29
Jan 8, 2026
Merged

[smg][ci] migrate validation tests to new infrastructure#16746
slin1237 merged 1 commit intomainfrom
smg-ci-n/29

Conversation

@slin1237
Copy link
Collaborator

@slin1237 slin1237 commented Jan 8, 2026

Migrate ignore_eos and large_max_new_tokens tests from e2e_grpc to chat_completions using the new pytest fixture infrastructure.

Tests migrated:

  • TestIgnoreEOS.test_ignore_eos: Verifies ignore_eos=True continues generation beyond EOS token until max_tokens is reached
  • TestLargeMaxNewTokens.test_concurrent_chat_completions: Verifies concurrent requests with large token generation complete successfully

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors existing end-to-end validation tests for the SGLang model gateway. The primary goal is to transition these tests to a more modern and maintainable pytest fixture-based infrastructure, specifically for chat_completions. This change streamlines the testing process and aligns with the project's evolving testing standards, ensuring continued reliability of core features like ignore_eos and concurrent request handling.

Highlights

  • Test Infrastructure Migration: Validation tests for ignore_eos and large_max_new_tokens have been migrated from the older e2e_grpc framework to a new chat_completions based infrastructure utilizing pytest fixtures.
  • Specific Tests Migrated: The TestIgnoreEOS.test_ignore_eos test, which verifies generation beyond EOS tokens when ignore_eos=True, and TestLargeMaxNewTokens.test_concurrent_chat_completions, which checks concurrent requests with large token generation, are now part of the new infrastructure.
  • New Test File: A new test file, sgl-model-gateway/e2e_test/chat_completions/test_validation.py, has been added to house these refactored validation tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@slin1237 slin1237 added the run-ci label Jan 8, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates two validation tests, test_ignore_eos and test_concurrent_chat_completions, to the new pytest fixture-based infrastructure. The new test file is well-organized and the logic from the original tests has been preserved. I've provided a few suggestions to improve the code's robustness and maintainability, including making the tokenizer cache thread-safe, removing unused variables, and refactoring duplicated code.

Migrate ignore_eos and large_max_new_tokens tests from e2e_grpc to
chat_completions using the new pytest fixture infrastructure.

Tests migrated:
- TestIgnoreEOS.test_ignore_eos: Verifies ignore_eos=True continues
  generation beyond EOS token until max_tokens is reached
- TestLargeMaxNewTokens.test_concurrent_chat_completions: Verifies
  concurrent requests with large token generation complete successfully

Note: The concurrent test is simplified from the original which monitored
server logs to verify concurrency. The pool-based infrastructure does not
expose worker logs, so we verify successful completion instead.
@slin1237 slin1237 merged commit fbc2488 into main Jan 8, 2026
56 of 62 checks passed
@slin1237 slin1237 deleted the smg-ci-n/29 branch January 8, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments