Skip to content

[smg] Work around sglang's notorious orphan process problem#16756

Merged
slin1237 merged 1 commit intomainfrom
smg-ci-n/33
Jan 8, 2026
Merged

[smg] Work around sglang's notorious orphan process problem#16756
slin1237 merged 1 commit intomainfrom
smg-ci-n/33

Conversation

@slin1237
Copy link
Collaborator

@slin1237 slin1237 commented Jan 8, 2026

sglang is notorious for getting stuck during model loading and leaving orphan child processes (TP workers) hanging around holding GPU memory. There's even a dedicated killall_sglang.sh script for this very reason.

This commit works around these issues in e2e tests:

  • Kill entire process group on terminate() instead of just parent process, since sglang doesn't clean up its children when the parent dies
  • Increase LAUNCH_STAGGER_DELAY from 5s to 10s because sglang can't handle multiple servers loading weights simultaneously without choking

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

sglang is notorious for getting stuck during model loading and leaving
orphan child processes (TP workers) hanging around holding GPU memory.
There's even a dedicated killall_sglang.sh script for this very reason.

This commit works around these issues in e2e tests:
- Kill entire process group on terminate() instead of just parent process,
  since sglang doesn't clean up its children when the parent dies
- Increase LAUNCH_STAGGER_DELAY from 5s to 10s because sglang can't
  handle multiple servers loading weights simultaneously without choking
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@slin1237 slin1237 added the run-ci label Jan 8, 2026
@slin1237 slin1237 merged commit ee71e77 into main Jan 8, 2026
76 of 81 checks passed
@slin1237 slin1237 deleted the smg-ci-n/33 branch January 8, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments