[Bugfix] fix a obvious logic error

[lingebeng]

Fix a obvious logic error

cc @merrymercy @Fridge003 @ispobock

[gemini-code-assist]

Summary of Changes

Hello @lingebeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical logical flaw in the dependency configuration for the 'av' package across the project's pyproject.toml files. By changing a boolean 'AND' operator to an 'OR' operator in the platform machine checks, the system will now correctly identify and install the 'av' package on a wider range of ARM-based Linux systems, specifically 'arm64' and 'armv7l' architectures. This fix ensures that the project's dependencies are resolved as intended, preventing potential installation issues or runtime errors on these platforms.

Highlights

• Dependency Logic Correction: Corrected a logical error in the dependency specification for the 'av' package within both pyproject.toml files.
• Platform Compatibility: Ensured the 'av' package is correctly installed on Linux systems with either 'arm64' or 'armv7l' architectures by changing a boolean 'AND' to an 'OR' operator.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/pyproject.toml
  • Modified the 'av' dependency condition from platform_machine == 'arm64' and platform_machine == 'armv7l' to platform_machine == 'arm64' or platform_machine == 'armv7l' to correctly target ARM architectures.
• python/pyproject_xpu.toml
  • Modified the 'av' dependency condition from platform_machine == 'arm64' and platform_machine == 'armv7l' to platform_machine == 'arm64' or platform_machine == 'armv7l' to correctly target ARM architectures.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a logic error in the dependency specifiers for the av package in both pyproject.toml and pyproject_xpu.toml. The original condition platform_machine == 'arm64' and platform_machine == 'armv7l' would never be true. The change from and to or resolves this issue. I've added a couple of suggestions to improve the readability of these conditions by using the in operator, which is more concise for this type of check.

[gemini-code-assist]

While the logical error is fixed, this condition can be made more concise and readable by using the in operator.

Suggested change

	"av ; sys_platform == 'linux' and (platform_machine == 'aarch64' or platform_machine == 'arm64' or platform_machine == 'armv7l')",
	"av ; sys_platform == 'linux' and platform_machine in ('aarch64', 'arm64', 'armv7l')",

[gemini-code-assist]

While the logical error is fixed, this condition can be made more concise and readable by using the in operator.

Suggested change

	"av ; sys_platform == 'linux' and (platform_machine == 'aarch64' or platform_machine == 'arm64' or platform_machine == 'armv7l')",
	"av ; sys_platform == 'linux' and platform_machine in ('aarch64', 'arm64', 'armv7l')",