[Fix] Fix bugs and refactor codes in lora for better scalability.#3652
Merged
zhaochenyang20 merged 23 commits intosgl-project:mainfrom Feb 20, 2025
Merged
[Fix] Fix bugs and refactor codes in lora for better scalability.#3652zhaochenyang20 merged 23 commits intosgl-project:mainfrom
zhaochenyang20 merged 23 commits intosgl-project:mainfrom
Conversation
-Introduce LoRAAdaptor and LoRAModelCase dataclasses for better test case management -Implement dynamic tolerance settings based on model and adaptor
- Implement a TODO for supporting more modules in the future
aoshen524
requested review from
Ying1123,
merrymercy and
zhyncs
as code owners
Fridge003
reviewed
Feb 18, 2025
Fridge003
reviewed
Feb 18, 2025
Ying1123
approved these changes
Feb 18, 2025
Contributor
Ying1123
left a comment
Ying1123
left a comment
There was a problem hiding this comment.
LGTM. Let's merge it after Baizhou's approval.
Collaborator
|
LGTM |
5 tasks
7 tasks
aoshen524
added a commit
to aoshen524/sglang
that referenced
this pull request
Mar 10, 2025
…l-project#3652) Co-authored-by: ShenAo1111 <1377693092@qq.com> Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Motivation
#3414 reports issues regarding limited model support compared to test_generation_models.py. This PR refines the LoRA dataclasses and tests several trending LoRA models on Hugging Face, uncovering some bugs and providing warnings for them to be addressed later.
Modifications
Checklist