Skip to content

Multiple tiny code cleanups#4608

Merged
zhyncs merged 6 commits intosgl-project:mainfrom
fzyzcjy:feat/deepseek_remove_shape
Mar 23, 2025
Merged

Multiple tiny code cleanups#4608
zhyncs merged 6 commits intosgl-project:mainfrom
fzyzcjy:feat/deepseek_remove_shape

Conversation

@fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Mar 20, 2025

Motivation

When doing #4068, it seems these several lines are not needed, and thus remove them to make that PR neater

EDIT: One more tiny cleanup suggested by @ch-wan in #4610 (comment)

Modifications

Checklist

@fzyzcjy fzyzcjy marked this pull request as ready for review March 20, 2025 06:36
@fzyzcjy fzyzcjy mentioned this pull request Mar 20, 2025
6 tasks
@fzyzcjy fzyzcjy changed the title Tiny cleanup deepseek_v2.py Multiple tiny code cleanups Mar 23, 2025
@fzyzcjy fzyzcjy requested a review from HaiShaw as a code owner March 23, 2025 01:30
@zhyncs zhyncs merged commit c6d549e into sgl-project:main Mar 23, 2025
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants