Allow benchmarking each forward pass in e2e systems#4666
Open
fzyzcjy wants to merge 80 commits intosgl-project:mainfrom
Open
Allow benchmarking each forward pass in e2e systems#4666fzyzcjy wants to merge 80 commits intosgl-project:mainfrom
fzyzcjy wants to merge 80 commits intosgl-project:mainfrom
Conversation
This reverts commit 4240966.
Collaborator
Author
|
Ping me when this PR is to be merged - currently I only resolve conflicts in #4068, and will port the resolve code back here when pinged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On one hand,
bench_one_batchis great, but it is somehow buggy for complex scenarios (e.g. DeepSeek V3), partially because it bypasses all logic in real schedulers. On the other hand,bench_servingis great, but only provides one single e2e latency number, so we cannot know the breakdown of the number. Therefore, I made this tiny PR to allowbench_one_batch_serverto provide extra numbers about each single forward pass.Example command
Example output
This PR is based on #4699, so please subtract code diff from there
Modifications
Checklist