Revert "[deepep] fix: shared experts are not initialized when shared experts fusion is disabled"#5132
Closed
Revert "[deepep] fix: shared experts are not initialized when shared experts fusion is disabled"#5132
Conversation
…experts …" This reverts commit 4c54f44.
BBuf
requested review from
ByronHsu,
Ying1123,
hnyls2002,
ispobock,
merrymercy and
zhyncs
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5072
Set the default value of
n_share_experts_fusionto None, considering that in DS V3/R1, it automatically uses TP_SIZE to fill in the value ofn_share_experts_fusionto achieve the effect of being enabled by default. This modification actually disrupts our enabling logic, which is a misunderstanding.