Skip to content

[Security] Fixing vulnerabilities in the Dockerfile#5744

Closed
Swipe4057 wants to merge 17 commits intosgl-project:mainfrom
Swipe4057:Fixing_vulnerabilities
Closed

[Security] Fixing vulnerabilities in the Dockerfile#5744
Swipe4057 wants to merge 17 commits intosgl-project:mainfrom
Swipe4057:Fixing_vulnerabilities

Conversation

@Swipe4057
Copy link
Contributor

@Swipe4057 Swipe4057 commented Apr 25, 2025

Motivation

This PR aims to improve the security of SGLang's Docker image by upgrading the base image to a newer version with significantly fewer vulnerabilities. The current base image nvcr.io/nvidia/tritonserver:24.04-py3-min contains 69 vulnerabilities with exploitable exploits, while the newer nvcr.io/nvidia/tritonserver:24.12-py3-min version has only 17 vulnerabilities.

nvcr.io/nvidia/tritonserver:24.04-py3-min:
image

nvcr.io/nvidia/tritonserver:24.12-py3-min:
image

This upgrade is critically important for large corporations and enterprise users for several key security reasons:
Reduced Attack Surface
Mitigation of Known Exploits
Data exfiltration of sensitive model inputs/outputs
Privilege escalation attacks in containerized environments
Potential compromise of adjacent systems in Kubernetes clusters
Reduces findings in mandatory vulnerability scans

Modifications

Changed the base Docker image from nvcr.io/nvidia/tritonserver:24.04-py3-min to nvcr.io/nvidia/tritonserver:24.12-py3-min in sglang/docker/Dockerfile. Update linux-libc-dev and Pillow

Ubuntu22.04 to Ubuntu24.04!
CUDA_VERSION=12.6.3
Update to Pytorch 2.7.0 unlocked

Checklist

@adarshxs
Copy link
Collaborator

Cc @zhaochenyang20 @zhyncs

@zhaochenyang20
Copy link
Collaborator

wait for yineng, thanks!

@Swipe4057 Swipe4057 changed the title Fixing vulnerabilities [Security] Fixing vulnerabilities Apr 26, 2025
@Swipe4057
Copy link
Contributor Author

Swipe4057 commented May 6, 2025

@zhyncs I made a few more small changes to the Dockerfile to update apt and pip packages in order to completely eliminate all vulnerabilities. I can't run CI, and it seems it won't run with the modified Dockerfile. If that's the case, I'll need help running CI locally, as I don't have the necessary hardware and resources.

@Swipe4057 Swipe4057 changed the title [Security] Fixing vulnerabilities [Security] Fixing vulnerabilities in the Dockerfile May 22, 2025
@Swipe4057
Copy link
Contributor Author

zhyncs Ubuntu22.04 to Ubuntu24.04, CUDA_VERSION=12.6.3, Pytorch 2.7.0 unlocked

@Swipe4057 Swipe4057 closed this Jun 10, 2025
@Swipe4057 Swipe4057 deleted the Fixing_vulnerabilities branch August 17, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants