Skip to content

temporarily disable deepep-8-gpu and activate two small tests #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 1 commit into from
Jul 11, 2025
Merged

temporarily disable deepep-8-gpu and activate two small tests #7961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions .github/workflows/pr-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,33 +324,33 @@ jobs:
cd test/srt
python3 run_suite.py --suite per-commit-4-gpu-deepep

unit-test-deepep-8-gpu:
if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
github.event.pull_request.draft == false
runs-on: 8-gpu-runner
needs: [
unit-test-deepep-4-gpu,
]
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Install dependencies
run: |
bash scripts/ci_install_deepep.sh

- name: Run test
timeout-minutes: 20
run: |
cd test/srt
python3 run_suite.py --suite per-commit-8-gpu-deepep
# unit-test-deepep-8-gpu:
# if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
# github.event.pull_request.draft == false
# runs-on: 8-gpu-runner
# needs: [
# unit-test-deepep-4-gpu,
# ]
# steps:
# - name: Checkout code
# uses: actions/checkout@v4
#
# - name: Install dependencies
# run: |
# bash scripts/ci_install_deepep.sh
#
# - name: Run test
# timeout-minutes: 20
# run: |
# cd test/srt
# python3 run_suite.py --suite per-commit-8-gpu-deepep

finish:
if: always()
needs: [
unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu, unit-test-backend-4-gpu,
unit-test-backend-8-gpu, performance-test-1-gpu-part-1, performance-test-1-gpu-part-2, performance-test-2-gpu,
accuracy-test-1-gpu, accuracy-test-2-gpu, unit-test-deepep-4-gpu, unit-test-deepep-8-gpu,
accuracy-test-1-gpu, accuracy-test-2-gpu, unit-test-deepep-4-gpu, # unit-test-deepep-8-gpu,
]
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions test/srt/test_deepep_small.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def test_gsm8k(self):
self.assertGreater(metrics["accuracy"], 0.62)


@unittest.skip("covered in test_deepep_large.py")
# @unittest.skip("covered in test_deepep_large.py")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using unittest.skipUnless with an environment variable to conditionally enable this test. This makes the test's execution dependent on a clear condition, which is better for managing test suites in different CI environments.

import os

@unittest.skipUnless(os.environ.get("DEEPEP_8_GPU_DISABLED") is None, "covered in test_deepep_large.py")

class TestNoGatherdBuffer(CustomTestCase):
@classmethod
def setUpClass(cls):
Expand Down Expand Up @@ -239,7 +239,7 @@ def test_gsm8k(self):
self.assertGreater(metrics["accuracy"], 0.62)


@unittest.skip("covered in TestMTPWithTBO")
# @unittest.skip("covered in TestMTPWithTBO")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using unittest.skipUnless with an environment variable to conditionally enable this test. This makes the test's execution dependent on a clear condition, which is better for managing test suites in different CI environments.

import os

@unittest.skipUnless(os.environ.get("DEEPEP_8_GPU_DISABLED") is None, "covered in TestMTPWithTBO")

class TestMTP(CustomTestCase):
@classmethod
def setUpClass(cls):
Expand Down
Loading