[bugfix][npu]: move internal CACHING_URL from shell to workflow#8760
[bugfix][npu]: move internal CACHING_URL from shell to workflow#8760pkking wants to merge 3 commits intosgl-project:mainfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @pkking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request improves the usability and portability of the npu_ci_install_dependency.sh script by removing hardcoded references to an internal caching service. This change allows users to run the script directly without encountering issues related to inaccessible internal cache URLs, aligning with the goal of making the script more generally applicable.
Highlights
- Script Portability: Removed specific
aptandpipconfigurations that pointed to an internal caching service (cache-service.nginx-pypi-cache.svc.cluster.local). This ensures thenpu_ci_install_dependency.shscript can be run successfully in environments where this internal cache is not accessible, making it more portable for general use. - Dependency Installation: The script will now rely on default
aptandpiprepositories for dependency installation, rather than an internal, cluster-specific cache.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes a hardcoded, CI-specific cache URL from scripts/npu_ci_install_dependency.sh. This is a good change as it makes the script more portable and allows users to run it directly in different environments without modification. The change is clean, correct, and improves the maintainability of the script. I have no further comments.
…can use it directly Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
|
It has been confirmed that the modifications in this PR are unrelated to the failed test cases in the CI |
|
lgtm |
|
closed, already included in #8700 |
remove cache url from npu_ci_install_dependency.sh
so the user can use it directly
see: #8759
Motivation
Modifications
Accuracy Test
Benchmark & Profiling
Checklist