Set JAWTWindow:reqPixelScale before the DPI scaling factor is determined and fix AUTOMAX_PIXELSCALE #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned, so if GLCanvas.setSurfaceScale() has been called, the correct 'reqPixelScale' is available. It's possible to call GLCanvas.setSurfaceScale() before JAWTWindow has been created. Fix feature AUTOMAX_PIXELSCALE so the requested pixel scale is used.
gbburkhardt
added a commit
to gbburkhardt/WorldWindJava
that referenced
this pull request
Apr 2, 2023
…Set JAWTWindow:reqPixelScale before the DPI scaling factor is determined and fix AUTOMAX_PIXELSCALE" sgothel/jogl#112
gbburkhardt
added a commit
to gbburkhardt/WorldWindJava
that referenced
this pull request
Apr 8, 2023
… coordinate values instead of the AWT screen coordinates. Added Windows JOGL jar files that include sgothel/jogl#110 and sgothel/jogl#112. Noticed that some null pointer exceptions occurred during KMLViewer startup; added null pointer checks.
Contributor
Author
|
Needs more work. The drawable surface isn't the entire frame enclosing the GLCanvas. |
Owner
|
Just for the record, this is closed by now. See https://forum.jogamp.org/DPI-scaling-not-working-tp4042206p4042603.html |
markpet49
pushed a commit
to NASAWorldWind/WorldWindJava
that referenced
this pull request
Jul 24, 2023
…#262) * Fixes for DPI scaling. Mouse and select events now deliver GL surface coordinate values instead of the AWT screen coordinates. Added Windows JOGL jar files that include sgothel/jogl#110 and sgothel/jogl#112. Noticed that some null pointer exceptions occurred during KMLViewer startup; added null pointer checks. * Update for gluegen 9301bf1854 May 15 07:08:20 2023, jogl 900c35c6a4 May 15 06:47:22 2023 * Use DPI scaling to scale fonts rendered in the GLCanvas. * Update with gluegen/jogl code from 6/17/2023, gluegen commit 42bd110d9e, jogl commit 900c35c6a. Includes fix for jogl version of TextRenderer. Added Linux native jar files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set JAWTWindow:reqPixelScale before the DPI scaling factor is determined, so if GLCanvas.setSurfaceScale() has been called, the correct 'reqPixelScale' is available. It's possible to call GLCanvas.setSurfaceScale() before JAWTWindow has been created. Fix feature AUTOMAX_PIXELSCALE so the requested pixel scale is used.
I discovered the NASA WorldWind was setting reqPixelScale immediately after GLCanvas was created. The code in JAWTWindows ignored 'reqPixelScale' when setting up the 'hasPixelScale' value. I surmise that AUTOMAX_PIXELSCALE was intended to all a user to set the surface scale with the GLCanvas.setSurfaceScale() call, which sets 'reqPixelScale' These changes allow the override of using 'maxPixelScale' to set 'hasPixelScale'.
The call to GLCanvas.createJAWTDrawableAndContext() is made when the first GLCanvas.addNotify() call is made. The JAWTWindow is created, and JAWTWindow.lockSurface() causes the DPI scaling value to be determined in JAWTWindow.updatePixelScale().