Skip to content

fix(slider, scroll-area): use correct data-orientation attribute selectors #9380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunnypatell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(slider, scroll-area): use correct data-orientation attribute selectors #9380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/v4/registry/bases/base/ui/slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function Slider({

return (
<SliderPrimitive.Root
className="data-horizontal:w-full data-vertical:h-full"
className="data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full"
data-slot="slider"
defaultValue={defaultValue}
value={value}
Expand All @@ -36,7 +36,7 @@ function Slider({
>
<SliderPrimitive.Control
className={cn(
"cn-slider relative flex w-full touch-none items-center select-none data-disabled:opacity-50 data-vertical:h-full data-vertical:w-auto data-vertical:flex-col",
"cn-slider relative flex w-full touch-none items-center select-none data-disabled:opacity-50 data-[orientation=vertical]:h-full data-[orientation=vertical]:w-auto data-[orientation=vertical]:flex-col",
className
)}
>
Expand All @@ -46,7 +46,7 @@ function Slider({
>
<SliderPrimitive.Indicator
data-slot="slider-range"
className="cn-slider-range select-none data-horizontal:h-full data-vertical:w-full"
className="cn-slider-range select-none data-[orientation=horizontal]:h-full data-[orientation=vertical]:w-full"
/>
</SliderPrimitive.Track>
{Array.from({ length: _values.length }, (_, index) => (
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/bases/radix/ui/slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,18 @@ function Slider({
min={min}
max={max}
className={cn(
"cn-slider relative flex w-full touch-none items-center select-none data-disabled:opacity-50 data-vertical:h-full data-vertical:w-auto data-vertical:flex-col",
"cn-slider relative flex w-full touch-none items-center select-none data-disabled:opacity-50 data-[orientation=vertical]:h-full data-[orientation=vertical]:w-auto data-[orientation=vertical]:flex-col",
className
)}
{...props}
>
<SliderPrimitive.Track
data-slot="slider-track"
className="cn-slider-track bg-muted relative grow overflow-hidden data-horizontal:w-full data-vertical:h-full"
className="cn-slider-track bg-muted relative grow overflow-hidden data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full"
>
<SliderPrimitive.Range
data-slot="slider-range"
className="cn-slider-range absolute select-none data-horizontal:h-full data-vertical:w-full"
className="cn-slider-range absolute select-none data-[orientation=horizontal]:h-full data-[orientation=vertical]:w-full"
/>
</SliderPrimitive.Track>
{Array.from({ length: _values.length }, (_, index) => (
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/styles/style-lyra.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@

/* MARK: Scroll Area */
.cn-scroll-area-scrollbar {
@apply data-horizontal:h-2.5 data-horizontal:flex-col data-horizontal:border-t data-horizontal:border-t-transparent data-vertical:h-full data-vertical:w-2.5 data-vertical:border-l data-vertical:border-l-transparent;
@apply data-[orientation=horizontal]:h-2.5 data-[orientation=horizontal]:flex-col data-[orientation=horizontal]:border-t data-[orientation=horizontal]:border-t-transparent data-[orientation=vertical]:h-full data-[orientation=vertical]:w-2.5 data-[orientation=vertical]:border-l data-[orientation=vertical]:border-l-transparent;
}

.cn-scroll-area-thumb {
Expand Down Expand Up @@ -1113,11 +1113,11 @@

/* MARK: Slider */
.cn-slider {
@apply data-vertical:min-h-40;
@apply data-[orientation=vertical]:min-h-40;
}

.cn-slider-track {
@apply bg-muted rounded-none data-horizontal:h-1 data-horizontal:w-full data-vertical:h-full data-vertical:w-1;
@apply bg-muted rounded-none data-[orientation=horizontal]:h-1 data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-1;
}

.cn-slider-range {
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/styles/style-maia.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@

/* MARK: Scroll Area */
.cn-scroll-area-scrollbar {
@apply data-horizontal:h-2.5 data-horizontal:flex-col data-horizontal:border-t data-horizontal:border-t-transparent data-vertical:h-full data-vertical:w-2.5 data-vertical:border-l data-vertical:border-l-transparent;
@apply data-[orientation=horizontal]:h-2.5 data-[orientation=horizontal]:flex-col data-[orientation=horizontal]:border-t data-[orientation=horizontal]:border-t-transparent data-[orientation=vertical]:h-full data-[orientation=vertical]:w-2.5 data-[orientation=vertical]:border-l data-[orientation=vertical]:border-l-transparent;
}

.cn-scroll-area-thumb {
Expand Down Expand Up @@ -1138,11 +1138,11 @@

/* MARK: Slider */
.cn-slider {
@apply data-vertical:min-h-40;
@apply data-[orientation=vertical]:min-h-40;
}

.cn-slider-track {
@apply bg-muted rounded-4xl data-horizontal:h-3 data-horizontal:w-full data-vertical:h-full data-vertical:w-3;
@apply bg-muted rounded-4xl data-[orientation=horizontal]:h-3 data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-3;
}

.cn-slider-range {
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/styles/style-mira.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@

/* MARK: Scroll Area */
.cn-scroll-area-scrollbar {
@apply data-horizontal:h-2.5 data-horizontal:flex-col data-horizontal:border-t data-horizontal:border-t-transparent data-vertical:h-full data-vertical:w-2.5 data-vertical:border-l data-vertical:border-l-transparent;
@apply data-[orientation=horizontal]:h-2.5 data-[orientation=horizontal]:flex-col data-[orientation=horizontal]:border-t data-[orientation=horizontal]:border-t-transparent data-[orientation=vertical]:h-full data-[orientation=vertical]:w-2.5 data-[orientation=vertical]:border-l data-[orientation=vertical]:border-l-transparent;
}

.cn-scroll-area-thumb {
Expand Down Expand Up @@ -1140,11 +1140,11 @@

/* MARK: Slider */
.cn-slider {
@apply data-vertical:min-h-40;
@apply data-[orientation=vertical]:min-h-40;
}

.cn-slider-track {
@apply bg-muted rounded-md data-horizontal:h-3 data-horizontal:w-full data-vertical:h-full data-vertical:w-3;
@apply bg-muted rounded-md data-[orientation=horizontal]:h-3 data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-3;
}

.cn-slider-range {
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/styles/style-nova.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@

/* MARK: Scroll Area */
.cn-scroll-area-scrollbar {
@apply data-horizontal:h-2.5 data-horizontal:flex-col data-horizontal:border-t data-horizontal:border-t-transparent data-vertical:h-full data-vertical:w-2.5 data-vertical:border-l data-vertical:border-l-transparent;
@apply data-[orientation=horizontal]:h-2.5 data-[orientation=horizontal]:flex-col data-[orientation=horizontal]:border-t data-[orientation=horizontal]:border-t-transparent data-[orientation=vertical]:h-full data-[orientation=vertical]:w-2.5 data-[orientation=vertical]:border-l data-[orientation=vertical]:border-l-transparent;
}

.cn-scroll-area-thumb {
Expand Down Expand Up @@ -1138,11 +1138,11 @@

/* MARK: Slider */
.cn-slider {
@apply data-vertical:min-h-40;
@apply data-[orientation=vertical]:min-h-40;
}

.cn-slider-track {
@apply bg-muted rounded-full data-horizontal:h-1 data-horizontal:w-full data-vertical:h-full data-vertical:w-1;
@apply bg-muted rounded-full data-[orientation=horizontal]:h-1 data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-1;
}

.cn-slider-range {
Expand Down
6 changes: 3 additions & 3 deletions apps/v4/registry/styles/style-vega.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@

/* MARK: Scroll Area */
.cn-scroll-area-scrollbar {
@apply data-horizontal:h-2.5 data-horizontal:flex-col data-horizontal:border-t data-horizontal:border-t-transparent data-vertical:h-full data-vertical:w-2.5 data-vertical:border-l data-vertical:border-l-transparent;
@apply data-[orientation=horizontal]:h-2.5 data-[orientation=horizontal]:flex-col data-[orientation=horizontal]:border-t data-[orientation=horizontal]:border-t-transparent data-[orientation=vertical]:h-full data-[orientation=vertical]:w-2.5 data-[orientation=vertical]:border-l data-[orientation=vertical]:border-l-transparent;
}

.cn-scroll-area-thumb {
Expand Down Expand Up @@ -1134,11 +1134,11 @@

/* MARK: Slider */
.cn-slider {
@apply data-vertical:min-h-40;
@apply data-[orientation=vertical]:min-h-40;
}

.cn-slider-track {
@apply bg-muted rounded-full data-horizontal:h-1.5 data-horizontal:w-full data-vertical:h-full data-vertical:w-1.5;
@apply bg-muted rounded-full data-[orientation=horizontal]:h-1.5 data-[orientation=horizontal]:w-full data-[orientation=vertical]:h-full data-[orientation=vertical]:w-1.5;
}

.cn-slider-range {
Expand Down
Loading