Stabilize CLI integration tests and remove dark mode script lint warning #9582
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-mode-script Stabilize CLI integration helper and fix dark mode script lint warning
Contributor
|
@boracomet is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two focused improvements:
Stabilizes integration test execution by ensuring the shadcn CLI is built before test commands run (when index.js is missing).
Fixes a Next.js lint warning by replacing next/script beforeInteractive usage in DarkModeScript with a native <script> tag.
Changes
Added a build guard in test helpers to auto-build CLI on demand.
Added a helper-level test to verify CLI execution via --version.
Updated dark mode forwarding script implementation to remove @next/next/no-before-interactive-script-outside-document warning.
Validation
helpers.test.ts
pnpm --filter=tests typecheck
pnpm --filter=shadcn test
pnpm lint