-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Select default track by a list of preferences #9542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KimKyuHoi
wants to merge
31
commits into
shaka-project:main
Choose a base branch
from
KimKyuHoi:expand-language-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,804
−939
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
8f23120
feat: expand language config to accept arrays
KimKyuHoi 4ff2793
feat(ui): update UI for array-based language config
KimKyuHoi 80ecace
feat(demo): use navigator.languages for preferences
KimKyuHoi dea6127
test: update tests for array-based language config
KimKyuHoi 30f8130
test: add preferredAudioLanguages and preferredTextLanguages to demo …
KimKyuHoi d42afcc
Merge remote-tracking branch 'origin/main' into expand-language-configs
KimKyuHoi 75a4765
feat: Add structured preference typedefs (AudioPreference, TextPrefer…
KimKyuHoi d7bc60f
feat: Rewrite preference matching logic for structured preference arrays
KimKyuHoi 69da8ff
feat: Update UI components and demo app for structured preferences
KimKyuHoi f1541e2
test: Update all tests for structured preference system
KimKyuHoi 7a33217
fix: rename TextPreference.format to codec
KimKyuHoi b954821
fix: Apply code review feedback for structured preferences
KimKyuHoi a780155
fix: Update UI components for codec rename and formatting
KimKyuHoi 53bac31
fix: Update demo app for codec rename
KimKyuHoi d1afc6a
style: Format preference objects on multiple lines in tests
KimKyuHoi abb9f98
fix: rename TextPreference.codec back to format and add upgrade docs
KimKyuHoi 6b7f6b5
feat(demo): Add InputContainer.appendEntry and preference entry styles
KimKyuHoi 33322d6
feat(demo): Replace flat preference fields with inline expandable lists
KimKyuHoi 4f3ff9d
feat(demo): Serialize preference arrays as JSON in URL hash
KimKyuHoi 68b488b
docs: Add demo preference migration example to upgrade guide
KimKyuHoi 3b76bef
fix: rename AudioPreference.codecs to codec for consistency
KimKyuHoi 598b4f3
fix: Use correct AudioPreference.codec field name in UI
KimKyuHoi 2d9cb24
feat: Move preferForcedSubs into TextPreference.forced
KimKyuHoi a18bc63
feat(demo): Move Preferred UI Locale to Meta section
KimKyuHoi 8115b4b
fix: Set default preferredAudio with channelCount 2 for stereo
KimKyuHoi 1058d00
fix: Change optional boolean fields to non-optional in AudioPreferenc…
KimKyuHoi 2ed188a
fix(demo): Default channelCount to 2 in audio preference entries
KimKyuHoi cc34b9b
fix: Change spatialAudio and forced property docs to boolean type
KimKyuHoi be1d0dc
fix: Remove unnecessary default values and use optional chaining
KimKyuHoi 493c55a
fix: Change forced Field to Boolean
KimKyuHoi 1eecd9c
test: Added fields and fixed field names
KimKyuHoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the complexity of the new preferences, I think it's best to manage them in a popup/dialog with add, delete, and save buttons. And then display a summary in the side panel. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avelad Good suggestion! Instead of a popup/dialog, I'm thinking of an inline expandable list within the side panel — each preference entry shown as a numbered card with its own fields, plus Add/Delete buttons. This keeps it lightweight while fully supporting the array structure. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test your Demo code tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KimKyuHoi
Move Preferred UI locale to a new UI section (related to #2755)