Skip to content

feat: missing guild attributes#376

Merged
swarley merged 7 commits intoshardlab:mainfrom
Droid00000:feat/missing-guild-attributes
Mar 18, 2026
Merged

feat: missing guild attributes#376
swarley merged 7 commits intoshardlab:mainfrom
Droid00000:feat/missing-guild-attributes

Conversation

@Droid00000
Copy link
Copy Markdown
Collaborator

@Droid00000 Droid00000 commented Oct 25, 2025

Summary

Finally got around to doing this, but this adds all of the missing server attributes and fixes a few caching bugs related to server data. Previously, Server#update_data didn't account for nullable fields, because the code incorrectly assumed that all of the fields were optional, which they aren't. Following what we did with roles, I re-factored Server#update_data. Closes #419

Added

Server#locale
Server#description
Server#application_id
Server#max_member_count
Server#max_presence_count

Server#vanity_invite_code
Server#discovery_splash_id
Server#boost_progress_bar?
Server#vanity_invite_url
Server#discovery_splash_url

Server#system_channel_flags
Server#max_video_channel_members
Server#max_stage_video_channel_members

Server#mfa_level
Server#nsfw_level

Server#rules_channel
Server#safety_alerts_channel
Server#public_updates_channel

Server#modify=
API::Server#update!

Fixed

We could end up with a stale server cache because a field that was explicitly set to nil, e.g. someone disables the system channel, would never end up being updated in the local cache.

Previously, Server#splash didn't accept an image file. I updated the code so that it can process image files as well now.

@Droid00000 Droid00000 force-pushed the feat/missing-guild-attributes branch from 93279b1 to da52941 Compare October 25, 2025 03:21
@Droid00000 Droid00000 force-pushed the feat/missing-guild-attributes branch from 48608dd to 9090aa2 Compare October 25, 2025 03:30
@Droid00000 Droid00000 force-pushed the feat/missing-guild-attributes branch from 42c467a to df0ebae Compare February 22, 2026 05:05
@Droid00000 Droid00000 force-pushed the feat/missing-guild-attributes branch from 6d6123d to bbe6f9d Compare March 16, 2026 04:26
@swarley swarley merged commit 87785aa into shardlab:main Mar 18, 2026
7 checks passed
@Droid00000 Droid00000 deleted the feat/missing-guild-attributes branch March 18, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC - Support editing multiple attributes

2 participants