Merged
Conversation
93279b1 to
da52941
Compare
48608dd to
9090aa2
Compare
42c467a to
df0ebae
Compare
6d6123d to
bbe6f9d
Compare
Closed
swarley
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finally got around to doing this, but this adds all of the missing server attributes and fixes a few caching bugs related to server data. Previously,
Server#update_datadidn't account for nullable fields, because the code incorrectly assumed that all of the fields were optional, which they aren't. Following what we did with roles, I re-factoredServer#update_data. Closes #419Added
Server#localeServer#descriptionServer#application_idServer#max_member_countServer#max_presence_countServer#vanity_invite_codeServer#discovery_splash_idServer#boost_progress_bar?Server#vanity_invite_urlServer#discovery_splash_urlServer#system_channel_flagsServer#max_video_channel_membersServer#max_stage_video_channel_membersServer#mfa_levelServer#nsfw_levelServer#rules_channelServer#safety_alerts_channelServer#public_updates_channelServer#modify=API::Server#update!Fixed
We could end up with a stale server cache because a field that was explicitly set to
nil, e.g. someone disables the system channel, would never end up being updated in the local cache.Previously,
Server#splashdidn't accept an image file. I updated the code so that it can process image files as well now.