feat: SolidComponent let bindings can be used as TagValues#36
Merged
shayanhabibi merged 11 commits intomasterfrom Jul 20, 2025
Merged
feat: SolidComponent let bindings can be used as TagValues#36shayanhabibi merged 11 commits intomasterfrom
shayanhabibi merged 11 commits intomasterfrom
Conversation
…ling an invalid function call on runtime
…eComponent constructors. (#32)
…ling an invalid function call on runtime
…eComponent constructors. (#32)
# Conflicts: # Partas.Solid.Tests.Plugin/Compiled/Partas.Solid.Tests.Plugin.Compiled.fsproj # Partas.Solid.Tests/SolidTests.fs # Partas.Solid/Builder.fs
…nspile changelog: ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously could only use type constructors with
!@/TagValueto be used for components like Route etc.This was inconvenient, as there were plenty of cases where I wanted to pass the value of a JS constructor function that would have been sufficient as a let binding in F#, but for the sake of type safety, I would acquiesce.
Now the restriction is lifted. Any function call which outputs a HtmlElement will be eligible to be boxed into a
TagValue. HOWEVER, keep in mind that when the TagValue is rendered out, it will be rendered as a 'tag', meaning all the parameters passed to it will be packaged in apropsparam (the first param passed to the tag/func).