Skip to content

collect common deps to root workspace and use shiki instead of shikiji#67

Merged
higuaifan merged 3 commits intoshuimo-design:mainfrom
youuss:main
Feb 19, 2024
Merged

collect common deps to root workspace and use shiki instead of shikiji#67
higuaifan merged 3 commits intoshuimo-design:mainfrom
youuss:main

Conversation

@youuss
Copy link
Copy Markdown
Contributor

@youuss youuss commented Feb 19, 2024

🤔 Nature of this PR

  • 🐛 bug fix
  • ✨ new feature
  • 📝 documentation improvement
  • 🛝 demo code improvement
  • 🚀 component style/interaction improvement
  • 🏗️ ci/cd improvement
  • ♻️ refactoring
  • 🎨 code style optimization
  • ✅ test cases
  • 🔀 branch merging
  • 💡 other

🔗 Related Issue

#66

💡 Background and Solution

  1. we find some common deps which use different version, so we decide to collect common deps to root workspace
  2. shiki has already replaced of shikiji, so we use shiki instead of shikiji.

✅ Pre-merge Checklist

❗️Please self-check and check all options.❗️

  • Documentation is supplemented or not needed
  • Code demonstration is provided or not needed
  • TypeScript definitions are supplemented or not needed
  • Changelog is provided or not needed

@higuaifan higuaifan merged commit 78d2ac6 into shuimo-design:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants