Open
Conversation
Author
|
Ping |
dmitshur
reviewed
Jan 4, 2018
| switch m.(type) { | ||
| case *image.NRGBA: | ||
| invertImageNrgba(m.(*image.NRGBA)) | ||
| } |
Member
There was a problem hiding this comment.
Why this change? Can the type be something other than *image.NRGBA? If so, what can it be? Is doing nothing in those cases the best thing to do?
|
|
||
| // TODO: Implement. | ||
| void set_status_item_icon(struct image img) {} | ||
|
|
Member
There was a problem hiding this comment.
Remove extra blank line at the end, it's not needed.
| } | ||
|
|
||
| // SetStatusIcon replaces the icon image data. | ||
| func SetStatusIcon(imageData []byte) { |
Member
There was a problem hiding this comment.
Given we already have trayhost.UpdateMenu to modify the menu items, it might make more sense to use more consistent naming.
How about UpdateIcon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #18
Use demonstrated at https://github.com/tmc/trayhost-demo/tree/master/osx