Skip to content

Matching vectors with python implementation#114

Open
armfazh wants to merge 4 commits intosigma-rs:mainfrom
armfazh:stable_prgn
Open

Matching vectors with python implementation#114
armfazh wants to merge 4 commits intosigma-rs:mainfrom
armfazh:stable_prgn

Conversation

@armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 25, 2026

This is the implementation that uses the CSRNG API discussed in mmaker/draft-irtf-cfrg-sigma-protocols#123

This implementation passes the test vectors

Changes;

Copy link

@cathieyun cathieyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits on test vector seeding and documentation, but overall this looks good! (Approving, pending those changes)

@armfazh armfazh requested a review from cathieyun February 27, 2026 02:12
Copy link

@cathieyun cathieyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cathieyun
Copy link

@mmaker can you take a look at this PR?
(Tagging you because I can't explicitly add you as a reviewer, as I don't have admin access.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants