Matching vectors with python implementation#114
Open
armfazh wants to merge 4 commits intosigma-rs:mainfrom
Open
Matching vectors with python implementation#114armfazh wants to merge 4 commits intosigma-rs:mainfrom
armfazh wants to merge 4 commits intosigma-rs:mainfrom
Conversation
cathieyun
approved these changes
Feb 26, 2026
cathieyun
left a comment
There was a problem hiding this comment.
Some nits on test vector seeding and documentation, but overall this looks good! (Approving, pending those changes)
|
@mmaker can you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation that uses the CSRNG API discussed in mmaker/draft-irtf-cfrg-sigma-protocols#123
This implementation passes the test vectors
rust_prefix).Changes;
-- See Encoding of ark_secp256r1 Scalars must be big-endian arkworks-rs/spongefish#78
-- See p256 scalars must be big-endian (I2OSP and OS2IP) arkworks-rs/spongefish#79)