Change __getitem__ to handle a single item or a slice #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teque5
requested changes
Oct 23, 2023
Collaborator
Teque5
left a comment
Teque5
left a comment
There was a problem hiding this comment.
Change set looks good. It would be great if there was a test that worked for this method of accessing memory-mapped samples.
…i-channel case. Apply suggestions from code review and add test. Co-authored-by: Teque5 <[email protected]>
Collaborator
|
This is just about perfect, but follow this pattern and use a tempfile for the path. I know there are examples in there using |
Collaborator
|
Opened #32 as a reminder to fix those testing issues. |
Teque5
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #25 .
One other difference I noticed between slicing and
read_samples()that makes this slicing behavior slightly strange: a slice will not scale int8 data (or similar) to a float, whileread_sampleswill. Maybe that's not a bug and get_item should return truly "raw" data, but it could be warning-worthy.