Feature/typing 1 #39
Merged
Feature/typing 1 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start to add typing to module * fix bug so that when converting sigmf datetime to isoformat will now allow seconds with or without decimal
Teque5
force-pushed
the
feature/typing-1
branch
from
b11bfdb to
32bdb6a
Compare
Collaborator
Author
|
Would have like an approver, but this is uncontroversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to make typing consistent across the module, but this is just me getting started.
No material changes except
parse_iso8601_datetimenow catches an edge condition.