Skip to content

Support macOS .icon format#7684

Open
ErnSur wants to merge 4 commits intosignalapp:mainfrom
ErnSur:dev/icon-update
Open

Support macOS .icon format#7684
ErnSur wants to merge 4 commits intosignalapp:mainfrom
ErnSur:dev/icon-update

Conversation

@ErnSur
Copy link
Copy Markdown

@ErnSur ErnSur commented Jan 20, 2026

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A pnpm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

closes #7530

In order to support the macOS Tahoe icon styles (dark, clear, tinted) a new icon format must be used for the app icon asset.
In this PR I updated the electron-builder to a version that supports the.icon assets and replaced the legacy .icns asset with the new .icon one.

The .icon file was taken from the Signal iOS repository

New icons with light and dark style settings:
light
dark

In order to support macOS .icon format
icon asset taken from the iOS Signal repo
@ayumi-signal ayumi-signal self-assigned this Jan 21, 2026
@ErnSur ErnSur mentioned this pull request Feb 20, 2026
2 tasks
@cbrnr
Copy link
Copy Markdown

cbrnr commented Feb 26, 2026

Could you show a screenshot of the new icon in both light and dark mode, preferably next to some other macOS icons like Finder, Safari, Terminal, etc.? I'm asking because I manually replaced the Signal app icon with the one from iOS (right-click on the app, Get info, drag new icon onto the previewed icon), and it does not look good (it is too large compared to the others):

Screenshot 2026-02-26 at 07 49 45

Maybe that's just because manually replacing doesn't work, but I would still double-check if the new icon looks good, or if the iOS icon has to be adapted in some way.

@ErnSur
Copy link
Copy Markdown
Author

ErnSur commented Feb 26, 2026

Could you show a screenshot of the new icon in both light and dark mode

I updated the PR description with two screenshots.

@ayumi-signal Is this PR likely to be merged anytime soon?

@ayumi-signal
Copy link
Copy Markdown
Contributor

Hi, sorry for the delay. We've been trying to update electron-builder but with the last attempt there was an issue with the electron/universal dependency. Once we're able to update electron-builder then we can fix the icon.

@ErnSur
Copy link
Copy Markdown
Author

ErnSur commented Feb 26, 2026

Hi, sorry for the delay. We've been trying to update electron-builder but with the last attempt there was an issue with the electron/universal dependency. Once we're able to update electron-builder then we can fix the icon.

Is there an issue/PR where this problem is described in more detail?

@winzig
Copy link
Copy Markdown

winzig commented Apr 1, 2026

Yes is there an issue we can follow for the underlying blocking issue you described @ayumi-signal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No dark mode icon on macOS Tahoe

4 participants