Fixes #7784: Background artifact on emoji selection in message bubbles#7787
Open
apurv3170 wants to merge 1 commit intosignalapp:mainfrom
Open
Fixes #7784: Background artifact on emoji selection in message bubbles#7787apurv3170 wants to merge 1 commit intosignalapp:mainfrom
apurv3170 wants to merge 1 commit intosignalapp:mainfrom
Conversation
2 tasks
When selecting text containing inline emojis, a background image artifact was visible behind the emoji due to the browser's default selection highlight being applied to the hidden FunEmojiSelectionText span. Fix by setting background-color: transparent on ::selection for FunEmojiSelectionText, which removes the artifact while keeping the emoji selectable and copyable.
apurv3170
force-pushed
the
fix/emoji-selection-artifact
branch
from
0bfdd02 to
7cf8d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Bug: When selecting text containing inline emojis, a background image artifact was visible behind the emoji due to the browser's default selection highlight being applied to the hidden
FunEmojiSelectionTextspan.Fixes #7784 by setting
background-color: transparenton::selectionforFunEmojiSelectionText, which removes the artifact while keeping the emoji selectable and copyable.Screenshots:
Tested on Windows 11 OS