Fix issue #7552: Using app locale in sticker creator#7789
Open
sprt-schk wants to merge 1 commit intosignalapp:mainfrom
Open
Fix issue #7552: Using app locale in sticker creator#7789sprt-schk wants to merge 1 commit intosignalapp:mainfrom
sprt-schk wants to merge 1 commit intosignalapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Fixes issue #7552 by using the app's resolved locale in the sticker creator.
A IPC plus preload bridge has been added, so the sticker creator can read
getResolvedMessagesLocale().namefrom the main process.loadLocale()now uses that value obtained from the main process, before falling back tonavigator.language, which keeps sticker creator localization in sync with the rest of the app.The change has been manually verified, by configuring the Signal Desktop app with different languages and afterwards starting the sticker creator. Language did match in each test run. Verified on (Arch) Linux 64-bit.