Add possibility to create new GoPdf struct from existing pdf byte array#157
Add possibility to create new GoPdf struct from existing pdf byte array#157effeix wants to merge 1 commit intosignintech:masterfrom
Conversation
|
Hi @oneplus1000! I've created this PR a few days ago and would like to know if it is an acceptable feature! :) |
|
because I don't know much about "gofpdi", I would like you to add a go test function (you may add it to the gopdf_test.go Or maybe create a new file). Sorry for my late reply 😢 |
|
Hey, no problem! Sure, I will add a test to the PR, you're a 100% correct! |
| for i := 1; i < len(pageSizes); i++ { | ||
| gp.AddPage() | ||
|
|
||
| if i > 1 { |
There was a problem hiding this comment.
is it possible that i can be less than zero ?
|
Can anyone speed up the PR's review and merge process? Thanks a lot! |
|
Hi @hsluoyz! @oneplus1000 had asked me to provide a few tests for this feature. I have been quite busy latelly and not able to do it. As soon a I find some free time I'll add them and then we can merge. |
|
has this been added yet? I would like to load a pdf from s3 |
|
@oneplus1000 can you close this PR? It looks like it's been abandoned. |
6 participants
It would be nice to have the ability to create a new GoPdf from an existing PDF. It is possible using the Importer, so I added a function
NewFromBytes()that wraps the feature and creates a GoPdf instance from any byte array that stores a PDF file, importing the pages one by one.