Remove type construction from tree_hash benchmarks#93
Merged
michaelsproul merged 1 commit intosigp:mainfrom Mar 19, 2026
Merged
Remove type construction from tree_hash benchmarks#93michaelsproul merged 1 commit intosigp:mainfrom
michaelsproul merged 1 commit intosigp:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 70.15% 70.15%
=======================================
Files 22 22
Lines 1280 1280
=======================================
Hits 898 898
Misses 382 382 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
While doing some optimization experiments I noticed that we actually measure the type construction and the hashing in the same benchmarks which dilutes the apparent effect of any hashing optimizations.
Proposed Changes
Prevent the type construction from being timed by adding it into a "setup" closure which does not get benchmarked.
Doing it this way provides a "fresh" list every iteration so we avoid cache hits.
If we actually want to include benchmarks for construction we should make new benchmarks which specifically target that.
I also bumped
criterionto 0.8