remove unnecessary necessity of predeclared, known-at-declaration-time labelset for metrics#368
Open
dt-rush wants to merge 1 commit intosiimon:masterfrom
Open
remove unnecessary necessity of predeclared, known-at-declaration-time labelset for metrics#368dt-rush wants to merge 1 commit intosiimon:masterfrom
dt-rush wants to merge 1 commit intosiimon:masterfrom
Conversation
…e labelset for metrics + improved validation testing Change-type: minor Connects-to: siimon#298 Signed-off-by: dt-rush <nickp@balena.io>
Collaborator
|
How does this impact the TS types? |
|
Bumping this in the off chance there's something that can be done to get it merged (happy to roll up my sleeve and lend a hand), it'd be extremely useful when trying to expose metrics generated across an FFI boundary, like when using/writing node.js addons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see discussion in #298 for context
Change-type: minor
Connects-to: #298
Signed-off-by: dt-rush nickp@balena.io