Skip to content

fix getMetricsAsArray type #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbjornson merged 3 commits into from
Nov 13, 2021
Merged

fix getMetricsAsArray type #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2057ad
fix getMetricsAsArray type
Nov 10, 2021
4c1a6ad
add changelog for getMetricsAsArray type fix
Nov 10, 2021
e18c13d
move changelog to correct section
Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ project adheres to [Semantic Versioning](http://semver.org/).

### Changed

- types: fixed type for `registry.getMetricsAsArray()`

- changed: typedef for pushgateway to reflect js implementation.

Pushgateway's typedef were missing promise return type. That was
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class Registry {
/**
* Get all metrics as objects
*/
getMetricsAsArray(): Promise<metric[]>;
getMetricsAsArray(): metric[];

/**
* Remove a single metric
Expand Down