Merged
Conversation
voltbit
force-pushed
the
improve-exemplars-tests
branch
2 times, most recently
from
b010e69 to
2769d58
Compare
voltbit
force-pushed
the
improve-exemplars-tests
branch
from
2769d58 to
be89066
Compare
ngavalas
reviewed
Mar 12, 2023
lib/registry.js
Outdated
Comment on lines
+61
to
+62
| fullMetricLine = `${metricName}${labelsString} ${getValueAsString( | ||
| val.value, | ||
| )}`; |
Contributor
There was a problem hiding this comment.
nit: why did you declare it above? Should be fine to just let fullMetricLine = ... here.
- Fixed improper formating of exemplars - Added snapshot test for exemplars
voltbit
force-pushed
the
improve-exemplars-tests
branch
from
be89066 to
35d9295
Compare
SimenB
pushed a commit
that referenced
this pull request
Mar 13, 2023
Collaborator
|
I cherry-picked this onto master via 4a800f4. I think I applied the diff correctly 😅 |
Contributor
Author
|
It looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix exemplar formating
Fixes #554