Skip to content

Fixes description for setToCurrentTime to seconds instead of milliseconds#585

Merged
SimenB merged 3 commits intosiimon:masterfrom
alarobric:setToCurrentTime-unit
Sep 10, 2023
Merged

Fixes description for setToCurrentTime to seconds instead of milliseconds#585
SimenB merged 3 commits intosiimon:masterfrom
alarobric:setToCurrentTime-unit

Conversation

@alarobric
Copy link
Copy Markdown
Contributor

Fixes #568
This was broken since the change in #167 in v11.0.0

@SimenB
Copy link
Copy Markdown
Collaborator

SimenB commented Sep 7, 2023

Thanks! Could you update the changelog as well?

@alarobric
Copy link
Copy Markdown
Contributor Author

Sure, done now.

Copy link
Copy Markdown
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gauge.setToCurrentTime() : TypeScript definition says the time is set in milliseconds, but implementation sets the time in epoch seconds

2 participants