perf: improve the memory usage of histogram#606
Merged
SimenB merged 2 commits intosiimon:masterfrom Jan 16, 2024
Merged
Conversation
Collaborator
|
Should we do this for the other metric types as well? |
Contributor
Author
I checked only |
xsbchen
force-pushed
the
histogram-memory-improve
branch
from
aa76235 to
5b58cd4
Compare
Collaborator
|
@voltbit thoughts on this? Seems reasonable to me, but I have to admit I'm a bit unsure how this code works 😅 |
SimenB
approved these changes
Jan 12, 2024
Collaborator
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
From my read of it, this would work the same of exemplars are enabled, so should be good to go 👍
I'd like an extra pair of eyes on it, though
Contributor
|
Looks good to me. The data struct being there when exemplars are disabled was an overlook on my side I think. |
Contributor
Author
|
@zbjornson @siimon master, plz help to review it if you are free, thanks. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a use case where it generates a huge amount of histograms, each has more than 10 labels, we found the memory usage is quite high, under this scenario, we did an experiment and found that removing bucketExemplars field from histograms could save about
27%memory usage for each histogram instance, hope the maintainers could review and consider it