Conversation
Fix a crash when adding a Sense and there are multiple main Flex windows open. This is a kludge to work around the problem. Without this code the call to set m_listForm.Visible to false, in ComboListBox.HideComboBox(), will result in Windows choosing the wrong main Flex window to activate when there are multiple main Flex windows open. That causes the wrong MainWindowDelegate to receive the OnActivated() notification, which leads to SetCurrentStack() being called for the wrong undo stack. Then a little later, but still in the "m_listForm.Visible = false" call, we end up in PushUowOnUndoStack() for the wrong undo stack. The correct main Flex window is activated after we get out of the "m_listForm.Visible = false" call and its undo call stack is set to current, but we have a "UnsavedBundle" on the wrong call stack, which eventually leads to the crash reported in LT-22282. A possible better long term solution would be to execute all the menu choices through an event system and dispose of the ComboListBox immediately after the menu choice is made, instead of hiding it. Probably can do this when graphite is no longer needed, and we can use a regular menu.
papeh
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash when adding a Sense and there are multiple main Flex windows open.
This is a kludge to work around the problem.
Without this code the call to set m_listForm.Visible to false, in ComboListBox.HideComboBox(), will result in Windows choosing the wrong main Flex window to activate when there are multiple main Flex windows open. That causes the wrong MainWindowDelegate to receive the OnActivated() notification, which leads to SetCurrentStack() being called for the wrong undo stack. Then a little later, but still in the "m_listForm.Visible = false" call, we end up in PushUowOnUndoStack() for the wrong undo stack. The correct main Flex window is activated after we get out of the "m_listForm.Visible = false" call and its undo call stack is set to current, but we have a "UnsavedBundle" on the wrong call stack, which eventually leads to the crash reported in LT-22282.
A possible better long term solution would be to execute all the menu choices through an event system and dispose of the ComboListBox immediately after the menu choice is made, instead of hiding it. Probably can do this when graphite is no longer needed, and we can use a regular menu.
This change is