Fix LT-22475: The tab order is wrong for "Create and Edit" button#828
Merged
jtmaxwell3 merged 2 commits intomainfrom Apr 10, 2026
Merged
Fix LT-22475: The tab order is wrong for "Create and Edit" button#828jtmaxwell3 merged 2 commits intomainfrom
jtmaxwell3 merged 2 commits intomainfrom
Conversation
papeh
requested changes
Apr 10, 2026
Contributor
papeh
left a comment
papeh
left a comment
There was a problem hiding this comment.
I think a better place to set the tab order would be in the resx file.
Collaborator
Author
|
@papeh: We can't do it in the resx file since the Create and Edit button is only included in some contexts. When it is added, the downstream buttons have to have their TabIndex values incremented. |
Contributor
|
Tab orders are allowed to be nonconsecutive, so hiding the button should not cause a problem. |
papeh
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22475.
This change is