Images are silently overwritten

[AngryJKirk]

Let's say you have a page A with some embedded image.png that you uploaded previously.
Then you create a page B, completely unrelated and you also upload an image called image.png.

Both "image.png" files are completely unrelated to each other, but the because they all stored in the same folder the older image.png is getting overwritten without even saying a word to the user.

[zeus-web]

I can confirm that behaviour on SB-Version: 2.4.1-94-g4fdc8c1a-2026-02-08T14-23-01Z :-(

[rktjmp]

Is the correct behaviour here to

1. generate a non-conflicting name if a conflict-occurs
   • image.png + upload(image.png) = image.png xyzabc-image.png
     • This is probably the worst option because the behaviour is unpredictable, sometimes your file is what you think sometimes it's not.
   • image.png + upload(image.png) = image.png image.1.png
     • At least most of the filename is what you think, and a sequential integer makes it obvious it was a collision?
2. generate a (probably non-conflicting) prefix for all uploads
   • upload(image.png) = xyzabc-image.png
     • makes it harder to link anything
3. check if the file exists after getting the user filename and repeating the prompt on collision
   • image.png + upload(image.png) = another_name? = another_name? = ...
   • image.png + upload(image.png) = collision, new-name or keep existing to replace
     • must have non naive behaviour, if the new name also collides, repeat

I think 3 is probably the best option? Supports replacing, does not clobber, user will know what it ended up being called?

silverbullet/plugs/editor/upload.ts

Lines 32 to 42 in 4fdc8c1

	const finalFilePath = await editor.prompt(
	"File name for pasted document",
	resolveMarkdownLink(
	await editor.getCurrentPath(),
	isValidPath(file.name)
	? file.name
	: `file.${
	file.name.indexOf(".") !== -1 ? file.name.split(".").pop() : "txt"
	}`,
	),
	);

[zefhemel]

I'd vote for solution 3 yes: keep asking until the user comes up with an unused file name.