Skip to content

Conversation

@zatkins2
Copy link
Contributor

@zatkins2 zatkins2 commented Nov 11, 2025

I found sometimes that this assertion statement will fail due to floating point errors on phi0, with the pixel index being like <something>.99999999, which clearly indicates the pixel matches

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.60%. Comparing base (73d3f2b) to head (64a0958).

Files with missing lines Patch % Lines
pixell/lensing.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          37       37           
  Lines       11540    11540           
=======================================
  Hits         4340     4340           
  Misses       7200     7200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

msyriac
msyriac previously approved these changes Nov 11, 2025
@zatkins2
Copy link
Contributor Author

Sorry caught one more tiny bug (a typo), but this dimissed your approval

Copy link
Collaborator

@amaurea amaurea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I didn't write the original code, so Mat(?) should probably comment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants