Merged
Conversation
With this implementation of ping/pong responses, we avoid the Websocket connection being closed after 60 secs of inactivity
Mewbi
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this implementation of ping/pong responses, we avoid the Websocket connection being closed after 60 secs of inactivity.
To test the ping system working, open your broswer console and then run:
The way its implemented now, the front send starts the sequence each 10 seconds. When the sequence starts, a PING message is sent. If its not responded in 500ms, another PING is sent. This repeats 5 times, increasing the delay between messages in 500ms. If the server respond to any PONG sent, the connection is considered healthy, and sets another 10 seconds delay to start the next heartbeat sequence