Skip to content

feat: improvements from feedbacks#20

Merged
ySnoopyDogy merged 10 commits intomasterfrom
feat/feedback-improvements
May 5, 2024
Merged

feat: improvements from feedbacks#20
ySnoopyDogy merged 10 commits intomasterfrom
feat/feedback-improvements

Conversation

@ySnoopyDogy
Copy link
Member

In this PR, a couple of things were made. Here are what we did:

  • Add limits in frontend to all inputs.
  • Display all answers by default
  • Fix the eye emoji shrink problem
  • Fix all text overflow problems
  • Parse line breaks correctly in answers
  • Add a display to all inputs showing character limit
  • Implement a GET to /api/limits to get all limits. The response body expects the following schema:
{
  retrospective: {
    name: number;
    description: number;
  };
  question: {
    text: number;
  };
  answer: {
    text: number;
  };
};

If the requests gets a 404 response, it uses the current API values, hardcoded in client. With this we can deploy the front even without a backend deploy

Copy link
Member

@Mewbi Mewbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing break-all in retrospective description.

Suggestion to input limits
30 to 10 use text-gray-300
10 to 0 use text-red-500 and add a bounce animation to each character typed.

@ySnoopyDogy ySnoopyDogy force-pushed the feat/feedback-improvements branch from e0474e3 to 71471da Compare May 4, 2024 21:16
@ySnoopyDogy ySnoopyDogy requested a review from Mewbi May 4, 2024 21:17
@ySnoopyDogy ySnoopyDogy merged commit cf5a4eb into master May 5, 2024
@ySnoopyDogy ySnoopyDogy deleted the feat/feedback-improvements branch May 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants