fix: crash when webContents is detached before 'destroyed' event#196
Merged
sindresorhus merged 2 commits intosindresorhus:mainfrom Mar 19, 2026
Merged
Conversation
Handle the Electron 41 breaking change where WebContentsView.webContents becomes undefined after the underlying webContents is destroyed. electron/electron#50249
Contributor
Author
|
I have added a second commit to ensure we removed the event from the webContents we added it to. ElectronJS never made it clear if the events are safely unbound after destruction, so it could hold a reference and creates a small leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle Electron 41 breaking change where WebContentsView.webContents becomes undefined right before the webContents is destroyed.
electron/electron#50249