Add Copy Image option#79
Merged
sindresorhus merged 4 commits intosindresorhus:masterfrom Aug 30, 2019
Merged
Conversation
Owner
|
The implementation here is more complicated than I'd like. I think you instead should open an issue on https://github.com/electron/electron about adding an API to create a native image directly from an URL. They already have all the Chrome machinery to download images, so it would be better if they could handle it. Could be |
3 tasks
19186d0 to
75836cb
Compare
75836cb to
690ff63
Compare
690ff63 to
0cb711c
Compare
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
sindresorhus
reviewed
Aug 8, 2019
Owner
|
I think you could have spent more time on perfecting this PR. At this point, it would have been much faster for me to just implement it myself. |
Contributor
Author
|
Sorry about that, I’ll do better on future PRs. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sindresorhus
This PR follows up on sindresorhus/caprine#943.
A couple of mentions:
pngorjpgimages. I tried withwebp, for example, butelectron.nativeImagehas no support for it. I suppose we could convert topngorjpg.. thoughts?file://protocol or notrequestmodule for fetching the image bufferThanks!