Add blacklist to no-fn-reference-in-iterator rule to prevent false-positives
#172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Yes, but for |
Owner
|
Can you also turn the rule on again in eslint-plugin-unicorn/index.js Line 44 in 352ba4a |
sindresorhus
changed the title
no-fn-reference-in-iterator rule to prevent false-positives - fixes #121no-fn-reference-in-iterator rule to prevent false-positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #121. Currently only implemented a blacklist for
Async,async,_,React.childrenandPromise. It wasn't entirely clear what was meant byDoes this mean that if we pass in more than 1 argument to
map, it shouldn't do anything? Because this might be an issue forreduceandreduceRight.