Add prefer-query-selector rule
#198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
prefer-query-selector rule
sindresorhus
requested changes
Oct 28, 2018
rules/prefer-query-selector.js
Outdated
|
|
||
| const VALID_QUOTES = /([',",`])/; | ||
| const getRange = (prop, node) => [prop.start, node.arguments[0].end]; | ||
| const getReplacement = (ctx, identifierName, node) => { |
Owner
There was a problem hiding this comment.
ctx => context
Generally, use readable names instead of abbreviations.
test/prefer-query-selector.js
Outdated
| }, | ||
| { | ||
| code: 'document.getElementsByClassName("foo bar");', | ||
| errors: [{message: 'Prefer `querySelector` over `getElementsByClassName`.'}], |
Owner
There was a problem hiding this comment.
No need to repeat the error in every assertion. Just build them upfront, like done in https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/test/new-for-builtins.js
Owner
|
The rule needs to be added to the bottom of the list here: https://github.com/sindresorhus/eslint-plugin-unicorn#rules |
Owner
MrHen
reviewed
Oct 29, 2018
futpib
suggested changes
Nov 5, 2018
Owner
|
@janowsiany Ping :) |
…plugin-unicorn into prefer-query-selector
Contributor
Author
|
@sindresorhus sorry for such long delay, please revalidate. I decided to make it partly fixable only because i found template strings and other corner cases hard or impossible to fix. |
sindresorhus
approved these changes
Jan 14, 2019
Owner
|
This looks good to me now. Very nice work, @janowsiany 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #171