Skip to content

Conversation

@stroncium
Copy link
Contributor

@stroncium stroncium commented Feb 7, 2019

  • Added meta.type to rules
  • Added test to check if fixable rules got types
  • Updated new-rule.md

Fixes #202

@stroncium
Copy link
Contributor Author

stroncium commented Feb 7, 2019

@sindresorhus Oh, by the way, I've made quite a lot of pull requests, but I still plan to do at least some minor refactoring after functionality is verified. I also plan to finish the remaining tasks from issuehunt. I've looked around the code and it seems the style goes left and right in every single piece of code. So, is there some official guidelines/request regarding that?

I myself prefer to write compact code with minimal comments, though some complex parts might get hard to understand from a glance(we're talking AST manipulations here after all), but if needed I can tweak the style the way maintainer(s?) seem fitting.

@sindresorhus sindresorhus changed the title Added meta.type, test, updated new-rule.md, Closes #202 Add meta.type to rules Feb 7, 2019
@sindresorhus
Copy link
Owner

I've looked around the code and it seems the style goes left and right in every single piece of code. So, is there some official guidelines/request regarding that?

Not exactly sure what you mean. Can you link to some examples of what you're referring to? "Official guidelines" for what exactly?

@stroncium
Copy link
Contributor Author

Not exactly sure what you mean. Can you link to some examples of what you're referring to? "Official guidelines" for what exactly?

Comment density, code illustrative side(in a sense of being a good guide for new coming contributors), idiomatic vs readable vs expressive vs fast code, levels of DRY. But it's ok if there is no premade answers to those questions, a couple of reviews will be enough.

@sindresorhus sindresorhus merged commit 610a901 into sindresorhus:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the new rule meta.type property

2 participants