Add no-named-default rule
#2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Jan 23, 2025
Comment on lines
+102
to
+103
| 1 | import named from "foo";␊ | ||
| 2 | import defaultExport from "foo";␊ |
Collaborator
Author
There was a problem hiding this comment.
I choose to duplicate import instead of
import defaultExport from "foo";
const named = defaultExport;As mentioned in #2087 (comment) and #2087 (comment), because theoretically it can be a let, live binding is safer.
Anyway, it's just an edge case.
sindresorhus
requested changes
Jan 24, 2025
Collaborator
Author
|
@sindresorhus Thoughts? #2087 (comment) |
Co-authored-by: Sindre Sorhus <[email protected]>
# Conflicts: # test/package.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2087