Skip to content

Conversation

@otomad
Copy link
Contributor

@otomad otomad commented Feb 17, 2025

Close #2078 .

  • escape-case add an option to accept lowercase escape value.
  • number-literal-case add options to accept lowercase hexadecimal value, uppercase radix identifier and exponential notation.

@sindresorhus
Copy link
Owner

I prefer dropping the radixIdentifier and exponentialNotation option. Every added option adds an additional maintenance burden and I don't think we should add things just because. I doubt anyone will actually use them, and every user has to read, consider, and understand each option.

@otomad
Copy link
Contributor Author

otomad commented Mar 3, 2025

I prefer dropping the radixIdentifier and exponentialNotation option. Every added option adds an additional maintenance burden and I don't think we should add things just because. I doubt anyone will actually use them, and every user has to read, consider, and understand each option.

Should I also drop the "ignore" option? Which can convert 0XAbCd to 0xAbCd. If it's for readable code, I think it should also be dropped.

@sindresorhus
Copy link
Owner

Yes

@otomad
Copy link
Contributor Author

otomad commented Mar 3, 2025

Done.

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus requested a review from fisker March 8, 2025 11:54
@fisker fisker merged commit 0f6048c into sindresorhus:main Mar 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule proposal: Require escape sequences to use lowercase values

3 participants