prefer-code-point: Report cases that String.fromCharCode not called

[baevm]

Fixed #2613 bug with String.fromCharCode.bind(String), i hope I understood this comment correctly

[fisker]

This is not the correct solution, we should change the listerner to MemberExpresion.

Meaning, no matter how String.fromCharCode is used, it should be reported.

const x = String.fromCharCode

String.fromCharCode + 1

[fisker]

And the String.fromCharCode(code) condition above should be removed.

[fisker]

const create = () => ({
	CallExpression(node) {
		// Report `charCodeAt` call
	},
	MemberExpression() {
		// Report `String.fromCharCode`
	}
});

[fisker]

You can even try to use GlobalReferenceTracker which handles more cases, but it's hard to understand. I prefer MemberExpression check for now which is good enough.

[baevm]

my bad 🤦 , fixed in e075d07, also added extra test case for const x = String.fromCharCode

[fisker]

The logic is correct now, thank you!

We can improve the code quantity a little bit,

1. We can reuse the problem reporting part. something like function getProblem(node, replacement){...} should be good.
2. getReplacement...() can be inlined since they dont need return "replacement", we already know which case we are dealing.

[baevm]

done