Refactor the prevent-abbreviations rule
#337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futpib
reviewed
Jul 7, 2019
futpib
reviewed
Jul 7, 2019
futpib
reviewed
Jul 7, 2019
Contributor
futpib
left a comment
futpib
left a comment
There was a problem hiding this comment.
👍 for the quick follow-up
fisker
commented
Jul 7, 2019
rules/prevent-abbreviations.js
Outdated
| .map(originalIsInPascalCase ? pascalCase : name => name) | ||
| .sort(); | ||
| }; | ||
| let options = [[]]; |
Collaborator
Author
There was a problem hiding this comment.
this can be quick loop from 0 to limit, I will figure out later
Collaborator
Author
There was a problem hiding this comment.
It's cartesian product, I've done this before but forgot how to calculate
Contributor
There was a problem hiding this comment.
Why is changing getWordByWordReplacements even necessary here?
Collaborator
Author
There was a problem hiding this comment.
I want have a function can get replacements only by word, no matter what cases, file names is more complicated than variable names
Collaborator
Author
|
@futpib ready for review |
sindresorhus
changed the title
prevent-abbreviationsprevent-abbreviations rule
Owner
|
Thanks, @fisker 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done:
1, refact
getNameReplacements, It should handle more kinds of strings, hope @futpib don't mind2, update test fix #336 review