Fix CI tests #1207
Merged
Fix CI tests #1207
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 10, 2025
|
|
||
| const cwdNotExisting = {cwd: 'does_not_exist', expectedCode: 'ENOENT', expectedMessage: 'The "cwd" option is invalid'}; | ||
| const cwdTooLong = {cwd: '.'.repeat(1e5), expectedCode: 'ENAMETOOLONG', expectedMessage: 'The "cwd" option is invalid'}; | ||
| const cwdTooLong = {cwd: '.'.repeat(1e5), expectedCode: isWindows && majorNodeVersion >= 20 ? 'ENOENT' : 'ENAMETOOLONG', expectedMessage: 'The "cwd" option is invalid'}; |
Collaborator
Author
There was a problem hiding this comment.
When calling child_process.spawn() with a cwd that has a long name, the error.code is ENAMETOOLONG on Unix. It used to be that on Windows too, but since Node 24.2.0 it's ENOENT. I could not find the commit in the Node changelog that changed that behavior, but it's nothing that's impacted Execa's code, so it's ok.
ehmicky
commented
Aug 10, 2025
| t.is(exitCode, 1); | ||
| t.false(isTerminated); | ||
| t.true(message.includes('Error: getOneMessage() cannot be used: the parent process has already exited or disconnected')); | ||
| t.true(message.includes('Error: getOneMessage()')); |
Collaborator
Author
There was a problem hiding this comment.
Those tests rely on a race condition between the time it takes to spawn a process vs to send an IPC message. Those fixes help prevent that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some tests currently failing in CI.