handle token expire

[BlitzJB]

No description provided.

[BlitzJB]

I have done two things here:

• Update google scopes
• Handle for token expiration error

Only these scopes seem to work for me, while some have said the old scopes do work for them, this could just be google preserving backward compatibility. Also, setting OAUTHLIB_RELAX_TOKEN_SCOPE = True doesn't fix this

Token expiration left me confused for quite a while when I initially faced it, as it was something I expected flask-dance to handle out of the box, Adding this into the example might save a lot of people from puzzles

Kindly do let me know if I could make this PR more helpful. This is literally my first PR into an open-source project ❤️

[BlitzJB]

@singingwolfboy Could you take a look at this?

[singingwolfboy]

Kindly do let me know if I could make this PR more helpful. This is literally my first PR into an open-source project ❤️

First of all, thank you for the pull request, and welcome to the world of open source! Sorry it took me a few days to get to it; I do have other things going on in my life as well. 🙂

I have done two things here:

• Update google scopes
• Handle for token expiration error

Usually, it's a good idea to have one pull request per logical change. By "logical change", I mean an idea that should be discussed and reviewed separately. Smaller pull requests are easier to understand and review, and by splitting PRs like this, they can usually get reviewed and merged more quickly.

Only these scopes seem to work for me, while some have said the old scopes do work for them, this could just be google preserving backward compatibility. Also, setting OAUTHLIB_RELAX_TOKEN_SCOPE = True doesn't fix this

Interesting. What error message are you getting with the existing scopes? I haven't manually tested this code in awhile, and it's entirely possible that Google has changed their mind about what scopes they accept. If that's the case, then we should definitely update these scopes!

Token expiration left me confused for quite a while when I initially faced it, as it was something I expected flask-dance to handle out of the box, Adding this into the example might save a lot of people from puzzles

Flask-Dance has the capability to handle token expiration out of the box, and in fact it should do that for the Google configuration -- if you set offline=True. Google's documentation of this is really bad, but you can check the access_type value in this table. Essentially, the default access type is "online", meaning that the user needs to be present for refreshing OAuth tokens. If we use the "offline" access type, then Google passes a refresh token as well, so the access token can be refreshed without the user.

For this example repo, I really want the code to be as short and simple as possible: truly a minimalist example of how to make Flask-Dance work with Google. That means I don't want to add the try/except code, because the code works without it. However, I would gladly accept a change to the README or some other kind of documentation that explains this offline=True parameter, and when and why you would want to use it for token expiration.