Use new mochify, update dependencies, drop old node#132
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 137 137
=========================================
Hits 137 137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
75eddfc to
b83fd24
Compare
mroderick
approved these changes
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Caveat
I could not use ESBuild as the mochify bundler because it ran into a dual package hazard issue with
sinon.browserfield inpackage.jsonand decides to load./lib/sinon.js.exportsand chooses thebrowserfield from there, which points to./pkg/sinon-esm.js.I can override that behaviour with
conditions, but then ESBuild complains that it cannot resolveassert, while Browserify will happily shim that dependency transparently.Update: Consuming this with ESBuild doesn't work due to sinonjs/sinon#2519. Reverting this change makes it work again. ¯\(ツ)/¯
How to verify - mandatory
npm installnpm run lintnpm testnpm run test-cloudChecklist for author
npm run lintpasses