fix(agent): respect global skills toggle for skill tools

[Esubaalew]

Summary

• require tools.skills.enabled before registering find_skills / install_skill
• fixes config behavior where global skills disable was ignored

[CLAassistant]

All committers have signed the CLA.

[Copilot]

Pull request overview

This PR fixes agent tool registration so that the skill-related tools (find_skills, install_skill) are only registered when the global tools.skills.enabled toggle is enabled, aligning runtime behavior with the config model.

Changes:

• Add a global skills enable check before registering find_skills / install_skill.
• Prevent skill registry manager initialization when global skills are disabled.

Comments suppressed due to low confidence (2)

pkg/agent/loop.go:174

• Local boolean names use snake_case (e.g., skills_enabled), which is inconsistent with Go conventions and the surrounding camelCase locals in this function. Consider renaming these to skillsEnabled / findSkillsEnabled / installSkillEnabled (and updating uses) for readability and consistency.

		skills_enabled := cfg.Tools.IsToolEnabled("skills")
		find_skills_enable := cfg.Tools.IsToolEnabled("find_skills")
		install_skills_enable := cfg.Tools.IsToolEnabled("install_skill")
		if skills_enabled && (find_skills_enable || install_skills_enable) {

pkg/agent/loop.go:174

• The behavior change (gating find_skills/install_skill registration on the global skills toggle) is a config regression fix and would benefit from a unit test to prevent reintroductions. Suggest adding a test in pkg/agent/loop_test.go that sets cfg.Tools.Skills.Enabled=false while enabling cfg.Tools.FindSkills.Enabled / cfg.Tools.InstallSkill.Enabled, then asserts the default agent's tool registry does not contain find_skills or install_skill.

		if skills_enabled && (find_skills_enable || install_skills_enable) {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[afjcjsbx]

LGTM